Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 979353002: Disable Bluetooth discoverability when Easy Unlock app closes. (Closed)

Created:
5 years, 9 months ago by Tim Song
Modified:
5 years, 9 months ago
Reviewers:
xiyuan, Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Bluetooth discoverability when Easy Unlock app closes. This is a temporary line-saving solution for ease of merging. A proper separation of concerns will be done in a future CL. BUG=442831 Committed: https://crrev.com/b7e1ffd120bc04abe6c3a1b552b6dcb8bd3de287 Cr-Commit-Position: refs/heads/master@{#319801}

Patch Set 1 #

Patch Set 2 : safeguard in case of crash during setup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M chrome/browser/signin/easy_unlock_service.cc View 1 4 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Tim Song
5 years, 9 months ago (2015-03-05 23:03:35 UTC) #2
xiyuan
lgtm
5 years, 9 months ago (2015-03-05 23:09:45 UTC) #3
Ilya Sherman
LGTM
5 years, 9 months ago (2015-03-05 23:56:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979353002/20001
5 years, 9 months ago (2015-03-09 23:54:28 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 01:03:05 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 01:03:44 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7e1ffd120bc04abe6c3a1b552b6dcb8bd3de287
Cr-Commit-Position: refs/heads/master@{#319801}

Powered by Google App Engine
This is Rietveld 408576698