Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 979343002: handle null vertex or index buffers in batch (Closed)

Created:
5 years, 9 months ago by joshua.litt
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

handle null vertex or index buffers in batch BUG=skia: Committed: https://skia.googlesource.com/skia/+/4b31de8328bbf3ee789157ae1dc6fe7cc74c796a

Patch Set 1 #

Patch Set 2 : more claenup #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -2 lines) Patch
M gm/beziereffects.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 3 chunks +15 lines, -0 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 4 chunks +17 lines, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 3 chunks +15 lines, -0 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 5 chunks +25 lines, -0 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
joshualitt
Simple CL to check for null vertex / index buffers in batch
5 years, 9 months ago (2015-03-05 22:19:07 UTC) #2
bsalomon
5 years, 9 months ago (2015-03-05 22:25:18 UTC) #3
bsalomon
On 2015/03/05 22:25:18, bsalomon wrote: lgtm
5 years, 9 months ago (2015-03-05 22:25:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979343002/40001
5 years, 9 months ago (2015-03-05 22:28:24 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 22:33:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4b31de8328bbf3ee789157ae1dc6fe7cc74c796a

Powered by Google App Engine
This is Rietveld 408576698