Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 979323005: Refactor TypeFeedbackOracle to accept Handle<Name> instead of Handle<String>. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactor TypeFeedbackOracle to accept Handle<Name> instead of Handle<String>. R=verwaest@chromium.org BUG= Committed: https://crrev.com/c1d0f845a9a2539c87074c1a982dc30beb5c7624 Cr-Commit-Position: refs/heads/master@{#27111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M src/type-info.h View 3 chunks +6 lines, -9 lines 0 comments Download
M src/type-info.cc View 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
5 years, 9 months ago (2015-03-10 15:02:35 UTC) #1
Toon Verwaest
lgtm
5 years, 9 months ago (2015-03-10 15:05:45 UTC) #2
titzer
Committed patchset #1 (id:1) manually as c1d0f845a9a2539c87074c1a982dc30beb5c7624 (presubmit successful).
5 years, 9 months ago (2015-03-10 15:06:32 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:06:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1d0f845a9a2539c87074c1a982dc30beb5c7624
Cr-Commit-Position: refs/heads/master@{#27111}

Powered by Google App Engine
This is Rietveld 408576698