extensions/browser/api/printer_provider/printer_provider_api.cc - Issue 979303002: Update UI for extension destinations in print preview destination list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/printer_provider/printer_provider_api.cc

Issue 979303002: Update UI for extension destinations in print preview destination list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/search/destination_list_item.js ('K') | « extensions/browser/api/printer_provider/printer_provider_api.h ('k') | extensions/browser/api/printer_provider/printer_provider_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/printer_provider/printer_provider_api.cc

diff --git a/extensions/browser/api/printer_provider/printer_provider_api.cc b/extensions/browser/api/printer_provider/printer_provider_api.cc

index a74838d172bf70b1880df74c4cbe83f3bc0209c7..ca473106004ddd98ab4466ea7ed95fb427a01aae 100644

--- a/extensions/browser/api/printer_provider/printer_provider_api.cc

+++ b/extensions/browser/api/printer_provider/printer_provider_api.cc

@@ -524,6 +524,7 @@ void PrinterProviderAPIImpl::OnGetPrintersResult(

printer->SetString("id",

GeneratePrinterId(extension->id(), internal_printer_id));

printer->SetString("extensionId", extension->id());

+ printer->SetString("extensionName", extension->name());

printer_list.Append(printer.release());

}