chrome/browser/resources/print_preview/search/destination_list_item.html - Issue 979303002: Update UI for extension destinations in print preview destination list

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/print_preview/search/destination_list_item.html

Issue 979303002: Update UI for extension destinations in print preview destination list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/print_preview/data/local_parsers.js ('K') | « chrome/browser/resources/print_preview/search/destination_list_item.css ('k') | chrome/browser/resources/print_preview/search/destination_list_item.js » ('j') | chrome/browser/resources/print_preview/search/destination_list_item.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <li id="destination-list-item-template" class="destination-list-item" hidden	1 <li id="destination-list-item-template" class="destination-list-item" hidden

2 tabindex="0">	2 tabindex="0">

3 <span class="destination-list-item-content">	3 <span class="destination-list-item-content">

4 <img class="destination-list-item-icon" alt="">	4 <img class="destination-list-item-icon" alt="">

5 <span class="destination-list-item-name"></span>	5 <span class="destination-list-item-name"></span>

6 <span class="offline-status" hidden></span>	6 <span class="offline-status" hidden></span>

7 <span class="register-promo" hidden>	7 <span class="register-promo" hidden>

8 <button i18n-content="registerPromoButtonText"	8 <button i18n-content="registerPromoButtonText"

9 class="register-promo-button">	9 class="register-promo-button">

10 </button>	10 </button>

11 </span>	11 </span>

	12 <span class="extension-controlled-indicator" hidden>

	13 <span class="extension-name"></span>

	14 <span class="extension-icon" role="button" tabindex="0"></span>
	Aleksey Shlyapnikov 2015/03/06 00:27:39 Why don't we want to use extension icon as destina Why don't we want to use extension icon as destination-list-item-icon, as it used to be? If it's a button, you'll need alt text for accessibility, tbarzic 2015/03/06 03:16:11 We want the icon to link to the extension webui wi Show quoted text On 2015/03/06 00:27:39, Aleksey Shlyapnikov wrote: > Why don't we want to use extension icon as destination-list-item-icon, as it > used to be? If it's a button, you'll need alt text for accessibility, We want the icon to link to the extension webui with the extension highlighted, so it would be strange if some destination-list-item-icons were actionable and some are not. The title set for the icon in .js should take care of accessibility for the icon, right?
	15 </span>

12 </span>	16 </span>

13 </li>	17 </li>

OLD	NEW