Update UI for extension destinations in print preview destination list

chrome/browser/resources/print_preview/data/local_parsers.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /** Namespace that contains a method to parse local print destinations. */
   function LocalDestinationParser() {};
 
@@ skipping 64 matching lines @@
    * @return {!print_preview.Destination} Parsed destination.
    */
   ExtensionDestinationParser.parse = function(destinationInfo) {
     return new print_preview.Destination(
         destinationInfo.id,
         print_preview.Destination.Type.LOCAL,
         print_preview.Destination.Origin.EXTENSION,
         destinationInfo.name,
         false /* isRecent */,
         print_preview.Destination.ConnectionStatus.ONLINE,
-        {description: destinationInfo.description || '',

[tbarzic, 2015/03/05 23:50:59]

with extension name being displayed as hint for printer, the only thing
description is useful is to be matched against during destination search. Let me
know if you think that would be worth keeping it around (otherwise, I'll remove
it from the printerProvider API)

[Aleksey Shlyapnikov, 2015/03/06 00:27:39]

Would it occur to anyone to search for the printer by the extension name? Don't
we expect the name of the printer announced by the extension already be somehow
related to the extension? I'm not opposed to passing and exposing the extension
name, especially that it's already implemented.

One question though, the new field, why not pass extension name in the
description here? Just a thought, maybe we should let extension to specify the
printer description and default it to the extension name?

[tbarzic, 2015/03/06 03:16:11]

The point of showing extension name is not as much to enable user to search
destinations by extension name as it is to let the user know which extension
supplied the extension (and make it easier for the user to disable unwanted
extensions).

My first idea was to pass the extension name as part of the description, but
that would produce a weird result during the destination search if the extension
name is a hit (basically, we'd show the extension name twice: the extension name
is shown by default in the UI, and we also add description string that matches
search query).

-         extensionId: destinationInfo.extensionId});
+        {extensionId: destinationInfo.extensionId,
+         extensionName: destinationInfo.extensionName || ''});
   };
 
   // Export
   return {
     LocalDestinationParser: LocalDestinationParser,
     PrivetDestinationParser: PrivetDestinationParser,
     ExtensionDestinationParser: ExtensionDestinationParser
   };
 });