Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 979243005: Documentation for webview settings in Settings.in (Closed)

Created:
5 years, 9 months ago by rune
Modified:
5 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Documentation for webview settings in Settings.in Clarified what the wide viewport and overview mode settings are for. R=aelias@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191722

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M Source/core/frame/Settings.in View 1 3 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
rune
5 years, 9 months ago (2015-03-06 09:06:33 UTC) #1
aelias_OOO_until_Jul13
lgtm modulo suggestion https://codereview.chromium.org/979243005/diff/1/Source/core/frame/Settings.in File Source/core/frame/Settings.in (right): https://codereview.chromium.org/979243005/diff/1/Source/core/frame/Settings.in#newcode236 Source/core/frame/Settings.in:236: # For android.webkit.WebSettings.setLoadWithOverviewMode() How about linking ...
5 years, 9 months ago (2015-03-06 20:06:17 UTC) #2
aelias_OOO_until_Jul13
Also, everything between "useLegacyBackgroundSizeShorthandBehavior" and "forceZeroLayoutHeight" inclusively, plus "mainFrameClipsContent" and these two settings, are exclusively ...
5 years, 9 months ago (2015-03-06 20:15:51 UTC) #3
rune
On 2015/03/06 at 20:15:51, aelias wrote: > Also, everything between "useLegacyBackgroundSizeShorthandBehavior" and "forceZeroLayoutHeight" inclusively, plus ...
5 years, 9 months ago (2015-03-11 15:24:27 UTC) #4
rune
On 2015/03/06 at 20:06:17, aelias wrote: > lgtm modulo suggestion > > https://codereview.chromium.org/979243005/diff/1/Source/core/frame/Settings.in > File ...
5 years, 9 months ago (2015-03-11 15:24:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979243005/20001
5 years, 9 months ago (2015-03-11 15:26:34 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 18:39:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191722

Powered by Google App Engine
This is Rietveld 408576698