Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 979243004: Make automated branch creation gnumbd-save. (Closed)

Created:
5 years, 9 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
CC:
v8-dev, iannucci, kjellander_chromium
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make automated branch creation gnumbd-save. This makes now the same simplification as the chromium release scripts do. For creating branch B from a gnumbd'ed (aka real) commit X do: 1. Branch Y off the real X 2. Set refs/pending/heads/B to Y 3. Set refs/pending-tags/B to X 4. Set refs/heads/B to X The old algorithm tried to branch off the pending correspondent of X. That commit was determined by comparing tree objects of the real X and commits on pending. Unfortunately, multiple commits on one branch can refer to the same tree object, e.g., for commits P, Q, R with R being the revert of Q, P and R refer to the same tree object. TBR=tandrii@chromium.org NOTRY=true TEST=./script_test.py TEST=tools/release/create_release.py -a me -r you --dry-run Committed: https://crrev.com/934dd88d3b2cee6d3952676fc89844c41b77adf2 Cr-Commit-Position: refs/heads/master@{#27042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -24 lines) Patch
M tools/release/create_release.py View 3 chunks +5 lines, -19 lines 0 comments Download
M tools/release/test_scripts.py View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL
5 years, 9 months ago (2015-03-06 09:08:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979243004/1
5 years, 9 months ago (2015-03-06 13:10:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 13:10:27 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/934dd88d3b2cee6d3952676fc89844c41b77adf2 Cr-Commit-Position: refs/heads/master@{#27042}
5 years, 9 months ago (2015-03-06 13:10:44 UTC) #6
tandrii(chromium)
LGTM Yay, simlified :)
5 years, 9 months ago (2015-03-09 16:49:54 UTC) #7
agable
5 years, 9 months ago (2015-03-09 17:59:05 UTC) #8
Message was sent while issue was closed.
On 2015/03/09 at 16:49:54, tandrii wrote:
> LGTM
> 
> Yay, simlified :)

Nice

Powered by Google App Engine
This is Rietveld 408576698