tools/perf/measurements/thread_times.py - Issue 979243003: Simplify LayoutMetric.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/thread_times.py

Issue 979243003: Simplify LayoutMetric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | tools/perf/measurements/thread_times_unittest.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from telemetry.core.platform import tracing_category_filter	5 from telemetry.core.platform import tracing_category_filter

6 from telemetry.page import page_test	6 from telemetry.page import page_test

7 from telemetry.web_perf.metrics import layout	7 from telemetry.web_perf.metrics import layout

8	8

9 from measurements import timeline_controller	9 from measurements import timeline_controller

10 from metrics import timeline	10 from metrics import timeline

(...skipping 25 matching lines...) Expand all Loading...
36 self._timeline_controller.model.GetRendererThreadFromTabId(tab.id)	36 self._timeline_controller.model.GetRendererThreadFromTabId(tab.id)

37 if self._report_silk_details:	37 if self._report_silk_details:

38 metric.details_to_report = timeline.ReportSilkDetails	38 metric.details_to_report = timeline.ReportSilkDetails

39 metric.AddResults(self._timeline_controller.model, renderer_thread,	39 metric.AddResults(self._timeline_controller.model, renderer_thread,

40 self._timeline_controller.smooth_records, results)	40 self._timeline_controller.smooth_records, results)

41 layout_metric = layout.LayoutMetric()	41 layout_metric = layout.LayoutMetric()

42 layout_metric.AddResults(self._timeline_controller.model, renderer_thread,	42 layout_metric.AddResults(self._timeline_controller.model, renderer_thread,

43 self._timeline_controller.smooth_records, results)	43 self._timeline_controller.smooth_records, results)

44	44

45 def CleanUpAfterPage(self, _, tab):	45 def CleanUpAfterPage(self, _, tab):

46 self._timeline_controller.CleanUp(tab)	46 if self._timeline_controller:

	47 self._timeline_controller.CleanUp(tab)

OLD	NEW