Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Side by Side Diff: tools/telemetry/telemetry/web_perf/metrics/layout_unittest.py

Issue 979243003: Simplify LayoutMetric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import unittest 5 import unittest
6 6
7 from telemetry.results import page_test_results 7 from telemetry.results import page_test_results
8 from telemetry.page import page 8 from telemetry.page import page
9 from telemetry.web_perf.metrics import layout 9 from telemetry.web_perf.metrics import layout
10 from collections import namedtuple 10 from collections import namedtuple
11 from telemetry.web_perf.timeline_interaction_record import \
12 TimelineInteractionRecord
11 13
12 FakeEvent = namedtuple('Event', 'name, start, end') 14 FakeEvent = namedtuple('Event', 'name, start, end')
13 15
14 16
17 def RunLayoutMetric(events, interactions):
18 results = page_test_results.PageTestResults()
19 results.WillRunPage(page.Page('file://blank.html'))
20 layout.LayoutMetric()._AddResultsInternal(events, interactions, results)
21 return dict((value.name, value.values) for value in
22 results.current_page_run.values)
23
24
15 class LayoutMetricUnitTest(unittest.TestCase): 25 class LayoutMetricUnitTest(unittest.TestCase):
16 def testAvgStddev(self): 26 def testLayoutMetric(self):
17 results = page_test_results.PageTestResults() 27 # Let's iron out LayoutMetric before I rewrite the test.
18 results.WillRunPage(page.Page('file://blank.html')) 28 pass
19 events = map(FakeEvent._make, [(name, 42, 43) for name in
20 layout.LayoutMetric.EVENTS])
21 layout.LayoutMetric()._AddResults(events, results)
22 expected = set()
23 for name in layout.LayoutMetric.EVENTS.itervalues():
24 expected.add((name + '_avg', 1))
25 expected.add((name + '_stddev', 0))
26 actual = set((value.name, value.value) for value in
27 results.current_page_run.values)
28 self.assertEquals(expected, actual)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698