Issue 979223003: Makes DocumentView not assume it's getting services from the embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 979223003: Makes DocumentView not assume it's getting services from the embedder (Closed)

Created:
5 years, 9 months ago by sky

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Makes DocumentView not assume it's getting services from the embedder It's legal for the person embedding to supply null. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bc40eb1f169e3fd67b10fde9a5ecdf3d81f6faac

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	sky/viewer/document_view.cc	View		2 chunks	+12 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

sky

5 years, 9 months ago (2015-03-05 18:42:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bc40eb1f169e3fd67b10fde9a5ecdf3d81f6faac (presubmit successful).