Index application by URL and identity for multiprocess.

Index application by URL and identity for multiprocess.

This is a baby step in the direction of allowing to run multiple
instance of the same content handler. This will be needed when we enable
multi-process so that 2 application that use the same content handler
can be run in 2 processes.

R=davemoore@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/71f560743247332eb69bb05e64ba63965ded99df

[qsr, 2015-03-06 08:40:11]

gentle ping?

[DaveMoore, 2015-03-06 17:32:08]

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ap...
File shell/application_manager/application_manager.h (right):

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ap...
shell/application_manager/application_manager.h:248:
URLAndIdentityToShellImplMap url_to_shell_impl_;
This is no longer url_to_shell_impl_.

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ur...
File shell/application_manager/url_and_identity.cc (right):

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ur...
shell/application_manager/url_and_identity.cc:21: bool
URLAndIdentity::operator<(const URLAndIdentity& other) const {
This seems awfully expensive for a comparator. making pairs for each.

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ur...
File shell/application_manager/url_and_identity.h (right):

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ur...
shell/application_manager/url_and_identity.h:13: struct URLAndIdentity {
Please find a better name for this. URLAndIdentity is way too wordy.

[qsr, 2015-03-09 16:22:47]

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ap...
File shell/application_manager/application_manager.h (right):

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ap...
shell/application_manager/application_manager.h:248:
URLAndIdentityToShellImplMap url_to_shell_impl_;
On 2015/03/06 17:32:08, DaveMoore wrote:
> This is no longer url_to_shell_impl_. 

Done.

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ur...
File shell/application_manager/url_and_identity.cc (right):

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ur...
shell/application_manager/url_and_identity.cc:21: bool
URLAndIdentity::operator<(const URLAndIdentity& other) const {
On 2015/03/06 17:32:08, DaveMoore wrote:
> This seems awfully expensive for a comparator. making pairs for each.

 I'm kind of hoping that everything will be inlined. Am I too optimistic?
Anyway, changed to put the code in myself.

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ur...
File shell/application_manager/url_and_identity.h (right):

https://codereview.chromium.org/979203002/diff/1/shell/application_manager/ur...
shell/application_manager/url_and_identity.h:13: struct URLAndIdentity {
On 2015/03/06 17:32:08, DaveMoore wrote:
> Please find a better name for this. URLAndIdentity is way too wordy.

Changed to Identity, is that fine with you?

[qsr, 2015-03-10 14:46:20]

gentle ping?

[DaveMoore, 2015-03-10 17:26:12]

Sorry I kept missing this review.

LGTM, but I think you want to change all the variable names from
url_and_identity to just "identity", since the type includes the notion of url.

https://codereview.chromium.org/979203002/diff/20001/shell/application_manage...
File shell/application_manager/identity.h (right):

https://codereview.chromium.org/979203002/diff/20001/shell/application_manage...
shell/application_manager/identity.h:16: * of an application to another. It is
used by content handler that need to be
nit: content handlers

[qsr, 2015-03-12 14:04:39]

Updated variable names.

https://codereview.chromium.org/979203002/diff/20001/shell/application_manage...
File shell/application_manager/identity.h (right):

https://codereview.chromium.org/979203002/diff/20001/shell/application_manage...
shell/application_manager/identity.h:16: * of an application to another. It is
used by content handler that need to be
On 2015/03/10 17:26:12, DaveMoore wrote:
> nit: content handlers

Done.

[qsr, 2015-03-12 14:04:54]

Committed patchset #3 (id:40001) manually as
71f560743247332eb69bb05e64ba63965ded99df (presubmit successful).