Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issue 979153002: Add custom dm upload script to be used by the android framework (Closed)

Created:
5 years, 9 months ago by djsollen
Modified:
5 years, 9 months ago
Reviewers:
stephana, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add custom dm upload script to be used by the android framework Committed: https://skia.googlesource.com/skia/+/7bdc8dfaabdee59d1961a390418ae6aafe0f9e62

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
A platform_tools/android/tradefed/upload_dm_results.py View 1 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
djsollen
5 years, 9 months ago (2015-03-05 13:55:01 UTC) #2
borenet
https://codereview.chromium.org/979153002/diff/1/platform_tools/android/tradefed/upload_dm_results.py File platform_tools/android/tradefed/upload_dm_results.py (right): https://codereview.chromium.org/979153002/diff/1/platform_tools/android/tradefed/upload_dm_results.py#newcode7 platform_tools/android/tradefed/upload_dm_results.py:7: Nit: 2 lines between top-level items. https://codereview.chromium.org/979153002/diff/1/platform_tools/android/tradefed/upload_dm_results.py#newcode49 platform_tools/android/tradefed/upload_dm_results.py:49: # ...
5 years, 9 months ago (2015-03-05 15:48:47 UTC) #3
djsollen
https://codereview.chromium.org/979153002/diff/1/platform_tools/android/tradefed/upload_dm_results.py File platform_tools/android/tradefed/upload_dm_results.py (right): https://codereview.chromium.org/979153002/diff/1/platform_tools/android/tradefed/upload_dm_results.py#newcode7 platform_tools/android/tradefed/upload_dm_results.py:7: On 2015/03/05 15:48:47, borenet wrote: > Nit: 2 lines ...
5 years, 9 months ago (2015-03-05 15:52:26 UTC) #4
borenet
This LGTM but Stephan should probably take a look as well. https://codereview.chromium.org/979153002/diff/1/platform_tools/android/tradefed/upload_dm_results.py File platform_tools/android/tradefed/upload_dm_results.py (right): ...
5 years, 9 months ago (2015-03-05 15:53:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979153002/20001
5 years, 9 months ago (2015-03-05 16:59:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/7bdc8dfaabdee59d1961a390418ae6aafe0f9e62
5 years, 9 months ago (2015-03-05 17:14:01 UTC) #8
stephana
5 years, 9 months ago (2015-03-05 18:53:22 UTC) #9
Message was sent while issue was closed.
On 2015/03/05 17:14:01, I haz the power (commit-bot) wrote:
> Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/7bdc8dfaabdee59d1961a390418ae6aafe0f9e62

lgtm

Powered by Google App Engine
This is Rietveld 408576698