Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Issue 979133002: Fix progress check in auto-roller. (Closed)

Created:
5 years, 9 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix progress check in auto-roller. Using a git range check for checking progress is wrong when the last rolled revision and the revision candidate are on different branches. The range A..B will always show the commits from the merge-base of A and B until B. Better compare the tags of the last rolled revision and the candidate. The candidate's version must be strictly greater than what's in chromium. TBR=tandrii@chromium.org NOTRY=true TEST=./script_test.py Committed: https://crrev.com/f96e226011b1cd5e1cb959a36d9152de364be1ec Cr-Commit-Position: refs/heads/master@{#27021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M tools/release/auto_roll.py View 2 chunks +6 lines, -3 lines 0 comments Download
M tools/release/test_scripts.py View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 9 months ago (2015-03-05 13:39:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979133002/1
5 years, 9 months ago (2015-03-05 14:04:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 14:05:03 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f96e226011b1cd5e1cb959a36d9152de364be1ec Cr-Commit-Position: refs/heads/master@{#27021}
5 years, 9 months ago (2015-03-05 14:05:20 UTC) #6
tandrii(chromium)
5 years, 9 months ago (2015-03-09 10:46:03 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698