Recognize json media types as (non-image) mime types.

Recognize json media types as (non-image) mime types.

Extend the IsSupportedNonImageMimeType() predicate to also
recognize the JSON media types ("application/<something>+json")
( http://tools.ietf.org/html/rfc6839#section-3.1 )

Note that the 6839 RFC text allows the use of any toplevel type, not just "application/". No known uses outside of application/  however, hence we limit ourselves for now.

R=
BUG=278568
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242008

[sof, 2013-12-01 21:11:59]

At your leisure, please take a look.

(https://codereview.chromium.org/94893003/ for the changes needed on the Blink
side to follow through on this addition.)

[abarth-chromium, 2013-12-01 23:02:31]

lgtm

https://codereview.chromium.org/97913002/diff/1/net/base/mime_util.cc
File net/base/mime_util.cc (right):

https://codereview.chromium.org/97913002/diff/1/net/base/mime_util.cc#newcode523
net/base/mime_util.cc:523: MatchesMimeType("application/*+json", mime_type));
Is this how we check for +xml as well?

[sof, 2013-12-02 06:28:57]

https://codereview.chromium.org/97913002/diff/1/net/base/mime_util.cc
File net/base/mime_util.cc (right):

https://codereview.chromium.org/97913002/diff/1/net/base/mime_util.cc#newcode523
net/base/mime_util.cc:523: MatchesMimeType("application/*+json", mime_type));
On 2013/12/01 23:02:32, abarth wrote:
> Is this how we check for +xml as well?

Good question; there is no generic check for "xml media types" (i.e.,
application/ subtypes), but a few of the common ones are enumerated.
application/rss+xml is listed, but not application/soap+xml, for instance.

Beyond this part..should something with a MIME type application/rss+xml render
as text, or xml?

[commit-bot: I haz the power, 2013-12-02 06:36:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/97913002/1

[abarth-chromium, 2013-12-02 06:37:19]

On 2013/12/02 06:28:57, sof wrote:
> Beyond this part..should something with a MIME type application/rss+xml render
> as text, or xml?

That's a sore point that will start a long, ugly bug thread.  We render
application/rss+xml as text for security, but that makes some people unhappy.

[sof, 2013-12-02 06:41:46]

On 2013/12/02 06:37:19, abarth wrote:
> On 2013/12/02 06:28:57, sof wrote:
> > Beyond this part..should something with a MIME type application/rss+xml
render
> > as text, or xml?
> 
> That's a sore point that will start a long, ugly bug thread.  We render
> application/rss+xml as text for security, but that makes some people unhappy.

thanks, good to know. But recognizing other +xml kinds here might be worth it?
To render as text or not.

[abarth-chromium, 2013-12-02 06:46:50]

On 2013/12/02 06:41:46, sof wrote:
> thanks, good to know. But recognizing other +xml kinds here might be worth it?
> To render as text or not.

Those waters are more dangerous because being treated as XML gives the content
more authority (e.g., it gains the ability to execute script).  Unless we have a
specific reason, we should probably leave our +xml behavior as-is.

[tyoshino (SeeGerritForStatus), 2013-12-02 06:54:14]

I said we should handle application type data with the +json suffix as
application/json type in crbug.com/278568, but I re-read the RFC and it looks
+json can be used not only application type but for any MIME type. So, like
svg+xml, it's possible that we'll use +json for non-application media type.

I don't think it's necessary for now, but can you leave a comment in file or the
CL description saying that we include only application type for now?

[commit-bot: I haz the power, 2013-12-02 06:55:19]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[sof, 2013-12-02 08:09:58]

On 2013/12/02 06:54:14, tyoshino wrote:
> I said we should handle application type data with the +json suffix as
> application/json type in crbug.com/278568, but I re-read the RFC and it looks
> +json can be used not only application type but for any MIME type. So, like
> svg+xml, it's possible that we'll use +json for non-application media type.
> 
> I don't think it's necessary for now, but can you leave a comment in file or
the
> CL description saying that we include only application type for now?

Updated the description.

[tyoshino (SeeGerritForStatus), 2013-12-02 08:13:43]

lgtm

[sof, 2013-12-02 08:32:48]

thanks both; needs net/OWNERS approval.

[cbentzel, 2013-12-02 11:46:05]

LGTM

Should this land after the blink-side change?

If this lands without blink change it seems like the response will simply be
black holed.

[sof, 2013-12-02 11:51:44]

On 2013/12/02 11:46:05, cbentzel wrote:
> LGTM
> 
> Should this land after the blink-side change?
> 
> If this lands without blink change it seems like the response will simply be
> black holed.

Thanks. Yes, we need to land this first. I can wait until the other CL is
accepted & minimize the window between the two, if you like.

[commit-bot: I haz the power, 2013-12-19 21:01:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/97913002/1

[commit-bot: I haz the power, 2013-12-19 22:54:28]

Retried try job too often on win_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-19 23:00:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/97913002/1

[commit-bot: I haz the power, 2013-12-20 01:48:48]

Change committed as 242008