Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 9791053: Revert 129359 - [Sync] [Mac] Tweak OneClickSigninDialog nib (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
Reviewers:
akalin
CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Revert 129359 - [Sync] [Mac] Tweak OneClickSigninDialog nib Accidentally checked in some debug code. Make 'Enter' press the 'Start Syncing' button. Define the tab order Cancel -> Start Syncing -> (use defaults checkbox) -> Cancel. BUG=117899, 116685 TEST= Review URL: https://chromiumcodereview.appspot.com/9866048 TBR=akalin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -40 lines) Patch
M chrome/app/nibs/OneClickSigninDialog.xib View 4 chunks +3 lines, -35 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
akalin
8 years, 9 months ago (2012-03-28 04:05:54 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698