Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Unified Diff: services/icu_data/BUILD.gn

Issue 979043003: Fix shell_apptest for android. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/icu_data/BUILD.gn
diff --git a/services/icu_data/BUILD.gn b/services/icu_data/BUILD.gn
index 98b5a56071d16271de7e599c1fd177120e46e35d..6985902d8d764a7ccca716526b7fb126af771a0f 100644
--- a/services/icu_data/BUILD.gn
+++ b/services/icu_data/BUILD.gn
@@ -4,19 +4,11 @@
import("//mojo/public/mojo_application.gni")
import("//mojo/public/tools/bindings/mojom.gni")
+import("//mojo/tools/embed/rules.gni")
-action("embed_icu_data") {
- script = "embed_icu_data.py"
-
- inputs = [
- "$root_build_dir/icudtl.dat",
- ]
-
- outputs = [
- "$root_gen_dir/mojo/icu_data/data.cc",
- ]
-
- args = rebase_path(inputs + outputs, root_build_dir)
+embed_file("embed_icu_data") {
+ source = "$root_build_dir/icudtl.dat"
+ variable = "kICUData"
deps = [
"//third_party/icu:icudata",
@@ -26,8 +18,6 @@ action("embed_icu_data") {
mojo_native_application("icu_data") {
sources = [
"icu_data_impl.cc",
- "data.h",
- "$root_gen_dir/mojo/icu_data/data.cc",
]
deps = [

Powered by Google App Engine
This is Rietveld 408576698