Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 979043003: Fix shell_apptest for android. (Closed)

Created:
5 years, 9 months ago by qsr
Modified:
5 years, 9 months ago
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix shell_apptest for android. This CL introduces mojo/tools/embed/rules.gni that allows to embed a file in the data section of an object file. It refactors icu_data to use this, and uses it in shell_apptest to bundle the ping application. R=abarth@chromium.org, davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dc3d193b9cac268e3adfc22f2750a82bf9558376

Patch Set 1 #

Total comments: 1

Patch Set 2 : namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -93 lines) Patch
A mojo/tools/embed/data.h View 1 chunk +22 lines, -0 lines 0 comments Download
A mojo/tools/embed/embed_data.py View 1 1 chunk +76 lines, -0 lines 0 comments Download
A mojo/tools/embed/rules.gni View 1 1 chunk +49 lines, -0 lines 0 comments Download
M services/icu_data/BUILD.gn View 1 2 chunks +5 lines, -14 lines 0 comments Download
D services/icu_data/data.h View 1 chunk +0 lines, -17 lines 0 comments Download
D services/icu_data/embed_icu_data.py View 1 chunk +0 lines, -38 lines 0 comments Download
M services/icu_data/icu_data_impl.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M shell/BUILD.gn View 1 3 chunks +14 lines, -4 lines 0 comments Download
M shell/shell_apptest.cc View 1 6 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
qsr
Adam, can you look at icu_data and tell me if that's fine with you. Dave, ...
5 years, 9 months ago (2015-03-05 14:21:52 UTC) #1
qsr
gentle ping?
5 years, 9 months ago (2015-03-06 09:05:08 UTC) #2
DaveMoore
test changes LGTM, I don't know much about the rest
5 years, 9 months ago (2015-03-06 17:36:35 UTC) #3
abarth-chromium
lgtm https://codereview.chromium.org/979043003/diff/1/mojo/tools/embed/embed_data.py File mojo/tools/embed/embed_data.py (right): https://codereview.chromium.org/979043003/diff/1/mojo/tools/embed/embed_data.py#newcode53 mojo/tools/embed/embed_data.py:53: f.write('namespace embed {\n') Seems odd to put this ...
5 years, 9 months ago (2015-03-06 21:41:14 UTC) #4
qsr
On 2015/03/06 21:41:14, abarth wrote: > lgtm > > https://codereview.chromium.org/979043003/diff/1/mojo/tools/embed/embed_data.py > File mojo/tools/embed/embed_data.py (right): > ...
5 years, 9 months ago (2015-03-09 10:17:20 UTC) #5
qsr
Committed patchset #2 (id:20001) manually as dc3d193b9cac268e3adfc22f2750a82bf9558376 (presubmit successful).
5 years, 9 months ago (2015-03-09 10:17:42 UTC) #6
jamesr
5 years, 9 months ago (2015-03-09 17:58:56 UTC) #8
Message was sent while issue was closed.
apptests on the android tester are failing after this patch:

http://build.chromium.org/p/client.mojo/builders/Mojo%20Android%20Builder%20T...

Failed command: "/b/build/slave/mojo/build/src/mojo/tools/android_mojo_shell.py
'--origin=http://127.0.0.1:11347/' '--args-for=mojo:shell_apptests
--gtest_filter=ShellHTTPAppTest.Http' 'mojo:shell_apptests'"
------------------------------------------------------------------------
[1002/140313:ERROR:simple_index_file.cc(223)] Failed to write the temporary
index file
[INFO:network_fetcher.cc(70)] Caching mojo app
http://127.0.0.1:11347/tracing.mojo at
/data/data/org.chromium.mojo.shell/cache/tmp/abc04b542a7ecdc1e81c3f30106084c27926726280fdec7ee721b1fe7aaec1be.mojo
[INFO:network_fetcher.cc(70)] Caching mojo app
http://127.0.0.1:11347/shell_apptests.mojo at
/data/data/org.chromium.mojo.shell/cache/tmp/8515f065f37aa32e7163eef8d02bc5385b7593c86439119fe1de5a746f24cb00.mojo
Note: Google Test filter = ShellHTTPAppTest.Http
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ShellHTTPAppTest
[ RUN      ] ShellHTTPAppTest.Http

Powered by Google App Engine
This is Rietveld 408576698