Move code from StyleResolver to ViewportStyleResolver.

Move code from StyleResolver to ViewportStyleResolver.

@viewport rule collection is moved to ViewportStyleResolver. This removes
the last StyleResolver dependency from ScopedStyleResolver.

Removed an unnecessary null check for m_document in ViewportStyleResolver
which should always be non-null.

Moved resetAuthorStyle() to skip the call when the ScopedStyleResolver is
deleted immediately afterwards.

Load the viewport UA style into CSSDefaultStyleSheets once instead
of parsing it from InspectorPageAgent every time it is applied. Also
apply the UA style from ViewportStyleResolver instead of the
InspectorPageAgent to remove resolver dependencies from the inspector
code. The application of the UA style is controlled by a setting instead
of and OS(ANDROID) #if in Blink.

The introduction of the setting is a two-sided patch with this CL and [1].
[2] removes the OS(ANDROID) check completely.

[1] https://codereview.chromium.org/989963002/
[2] https://codereview.chromium.org/989973002/

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191747

[rune, 2015-03-05 10:38:53]

rune@opera.com changed reviewers:
+ dgozman@chromium.org, kochi@chromium.org

[dgozman, 2015-03-05 10:55:53]

https://codereview.chromium.org/979033003/diff/1/Source/core/css/CSSDefaultSt...
File Source/core/css/CSSDefaultStyleSheets.h (right):

https://codereview.chromium.org/979033003/diff/1/Source/core/css/CSSDefaultSt...
Source/core/css/CSSDefaultStyleSheets.h:42: RuleSet*
defaultViewportOverrideStyle() { return m_defaultViewportOverrideStyle.get(); }
I'd rename this to |defaultMobileViewportStyle| to emphasize it's content rather
than usage.

https://codereview.chromium.org/979033003/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorPageAgent.cpp (right):

https://codereview.chromium.org/979033003/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorPageAgent.cpp:1455: return
m_deviceMetricsOverridden && m_emulateMobileEnabled;
Since you are moving the heavy work into resolver itself, I'd prefer to switch
from InspectorInstrumentation call to a setting |useMobileViewportStyle|, which
InspectorPageAgent will toggle.

[rune, 2015-03-05 12:11:49]

rune@opera.com changed reviewers:
+ aelias@chromium.org

[rune, 2015-03-05 12:11:50]

https://codereview.chromium.org/979033003/diff/1/Source/core/css/CSSDefaultSt...
File Source/core/css/CSSDefaultStyleSheets.h (right):

https://codereview.chromium.org/979033003/diff/1/Source/core/css/CSSDefaultSt...
Source/core/css/CSSDefaultStyleSheets.h:42: RuleSet*
defaultViewportOverrideStyle() { return m_defaultViewportOverrideStyle.get(); }
On 2015/03/05 10:55:53, dgozman wrote:
> I'd rename this to |defaultMobileViewportStyle| to emphasize it's content
rather
> than usage.

Acknowledged.

https://codereview.chromium.org/979033003/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorPageAgent.cpp (right):

https://codereview.chromium.org/979033003/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorPageAgent.cpp:1455: return
m_deviceMetricsOverridden && m_emulateMobileEnabled;
On 2015/03/05 10:55:53, dgozman wrote:
> Since you are moving the heavy work into resolver itself, I'd prefer to switch
> from InspectorInstrumentation call to a setting |useMobileViewportStyle|,
which
> InspectorPageAgent will toggle.

You mean setting as in add to Settings.in?

If so, should that setting be used instead of #if OS(ANDROID) for normal default
style as well?

Adding aelias to get some Android feedback.

[dgozman, 2015-03-05 12:47:12]

>
https://codereview.chromium.org/979033003/diff/1/Source/core/inspector/Inspec...
> File Source/core/inspector/InspectorPageAgent.cpp (right):
> 
>
https://codereview.chromium.org/979033003/diff/1/Source/core/inspector/Inspec...
> Source/core/inspector/InspectorPageAgent.cpp:1455: return
> m_deviceMetricsOverridden && m_emulateMobileEnabled;
> On 2015/03/05 10:55:53, dgozman wrote:
> > Since you are moving the heavy work into resolver itself, I'd prefer to
switch
> > from InspectorInstrumentation call to a setting |useMobileViewportStyle|,
> which
> > InspectorPageAgent will toggle.
> 
> You mean setting as in add to Settings.in?
> 
> If so, should that setting be used instead of #if OS(ANDROID) for normal
default
> style as well?
> 
> Adding aelias to get some Android feedback.

Yes, that setting. We can definitely use it for android as well. That will
require a little bit more work through inspector, see textAutosizingEnabled
setting for example
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...).

[aelias_OOO_until_Jul13, 2015-03-05 21:07:28]

https://codereview.chromium.org/979033003/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorPageAgent.cpp (right):

https://codereview.chromium.org/979033003/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorPageAgent.cpp:1455: return
m_deviceMetricsOverridden && m_emulateMobileEnabled;
On 2015/03/05 12:11:50, rune wrote:
> On 2015/03/05 10:55:53, dgozman wrote:
> > Since you are moving the heavy work into resolver itself, I'd prefer to
switch
> > from InspectorInstrumentation call to a setting |useMobileViewportStyle|,
> which
> > InspectorPageAgent will toggle.
> 
> You mean setting as in add to Settings.in?
> 
> If so, should that setting be used instead of #if OS(ANDROID) for normal
default
> style as well?
> 
> Adding aelias to get some Android feedback.

Yes, I was already thinking myself that that #if OS(ANDROID) ought to be
replaced by a setting.  Go ahead.

[rune, 2015-03-08 00:44:36]

On 2015/03/05 21:07:28, aelias wrote:

> Yes, I was already thinking myself that that #if OS(ANDROID) ought to be
> replaced by a setting.  Go ahead.

Done. That is, it requires a two sided patch. See CLs in description.

[dgozman, 2015-03-08 06:32:11]

inspector lgtm

https://codereview.chromium.org/979033003/diff/40001/Source/core/css/resolver...
File Source/core/css/resolver/ViewportStyleResolver.cpp (right):

https://codereview.chromium.org/979033003/diff/40001/Source/core/css/resolver...
Source/core/css/resolver/ViewportStyleResolver.cpp:45: #include
"core/inspector/InspectorInstrumentation.h"
Not used anymore.

https://codereview.chromium.org/979033003/diff/40001/Source/web/WebSettingsIm...
File Source/web/WebSettingsImpl.cpp (right):

https://codereview.chromium.org/979033003/diff/40001/Source/web/WebSettingsIm...
Source/web/WebSettingsImpl.cpp:752:
m_settings->setUseMobileViewportStyle(enabled);
m_inspectorContorller->setUseMobileViewportStyle(enabled);

[rune, 2015-03-08 19:15:27]

https://codereview.chromium.org/979033003/diff/40001/Source/core/css/resolver...
File Source/core/css/resolver/ViewportStyleResolver.cpp (right):

https://codereview.chromium.org/979033003/diff/40001/Source/core/css/resolver...
Source/core/css/resolver/ViewportStyleResolver.cpp:45: #include
"core/inspector/InspectorInstrumentation.h"
On 2015/03/08 06:32:11, dgozman wrote:
> Not used anymore.

Done.

https://codereview.chromium.org/979033003/diff/40001/Source/web/WebSettingsIm...
File Source/web/WebSettingsImpl.cpp (right):

https://codereview.chromium.org/979033003/diff/40001/Source/web/WebSettingsIm...
Source/web/WebSettingsImpl.cpp:752:
m_settings->setUseMobileViewportStyle(enabled);
On 2015/03/08 06:32:11, dgozman wrote:
> m_inspectorContorller->setUseMobileViewportStyle(enabled);

Done.

[aelias_OOO_until_Jul13, 2015-03-10 17:12:07]

lgtm

[rune, 2015-03-11 09:14:49]

rune@opera.com changed reviewers:
+ jochen@chromium.org

[rune, 2015-03-11 09:14:49]

@jochen: public/ and Source/web

[jochen (gone - plz use gerrit), 2015-03-11 16:03:44]

lgtm

[rune, 2015-03-11 17:58:09]

The CQ bit was checked by rune@opera.com

[rune, 2015-03-11 17:58:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/979033003/#ps60001 (title:
"Addressed review issues")

[commit-bot: I haz the power, 2015-03-11 17:58:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/979033003/60001

[commit-bot: I haz the power, 2015-03-11 18:03:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-11 18:03:38]

Try jobs failed on following builders:
  android_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)

[rune, 2015-03-11 23:32:32]

The CQ bit was checked by rune@opera.com

[rune, 2015-03-11 23:32:34]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
aelias@chromium.org, dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/979033003/#ps80001 (title:
"Rebased")

[commit-bot: I haz the power, 2015-03-11 23:33:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/979033003/80001

[commit-bot: I haz the power, 2015-03-12 02:29:22]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191747