Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 978923005: Revert of check for inputs before reporting asColorFilter (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of check for inputs before reporting asColorFilter (patchset #7 id:110001 of https://codereview.chromium.org/967833003/) Reason for revert: Need to suppress these for rebaselining, so reverting for now. Regressions: Unexpected image-only failures (5) css3/filters/effect-brightness-clamping-hw.html [ ImageOnlyFailure ] css3/filters/effect-combined-hw.html [ ImageOnlyFailure ] virtual/slimmingpaint/css3/filters/effect-brightness-clamping-hw.html [ ImageOnlyFailure ] virtual/slimmingpaint/css3/filters/effect-combined-hw.html [ ImageOnlyFailure ] Upon coarse visual inspection of the diffs, it appears the differences are tiny. I think this is due to ComposeColorFilter now combinging heterogeneous filters and collapsing that part of the dag (i.e. a possible perf improvement). Original issue's description: > Use ComposeColorFilter in factory to collapse consecutive filters (when possible). > Change asColorFilter to reflect its reliance on the new factory behavior. > > patch from issue 967143002 at patchset 80001 (http://crrev.com/967143002#ps80001) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/dac843bf046c2cd79fd955cb177aee241d7a4b0c TBR=senorblanco@chromium.org,robertphillips@google.com,bsalomon@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/5c518a862264225f0a378e4728e037966ddf4cc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -41 lines) Patch
M src/effects/SkColorFilterImageFilter.cpp View 2 chunks +7 lines, -12 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +6 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
Created Revert of check for inputs before reporting asColorFilter
5 years, 9 months ago (2015-03-05 22:47:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978923005/1
5 years, 9 months ago (2015-03-05 22:47:24 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 22:47:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5c518a862264225f0a378e4728e037966ddf4cc2

Powered by Google App Engine
This is Rietveld 408576698