Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavedPasswordsPreferencesTest.java

Issue 978913004: Add auto sign in slider in Clank settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavedPasswordsPreferencesTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavedPasswordsPreferencesTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavedPasswordsPreferencesTest.java
index 9e4cf8b8de0e38432d69f19133d71b464d60505a..95753c02a701460265143e5271b1028fc99b92d6 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavedPasswordsPreferencesTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavedPasswordsPreferencesTest.java
@@ -6,13 +6,16 @@ package org.chromium.chrome.browser.preferences.password;
import android.test.suitebuilder.annotation.SmallTest;
+import org.chromium.base.CommandLine;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
+import org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference;
import org.chromium.chrome.browser.preferences.ChromeSwitchPreference;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.preferences.Preferences;
import org.chromium.chrome.browser.preferences.PreferencesTest;
import org.chromium.chrome.shell.ChromeShellTestBase;
+import org.chromium.content.common.ContentSwitches;
/**
* Tests for the "Save Passwords" settings screen.
@@ -23,6 +26,7 @@ public class SavedPasswordsPreferencesTest extends ChromeShellTestBase {
protected void setUp() throws Exception {
super.setUp();
startChromeBrowserProcessSync(getInstrumentation().getTargetContext());
+ CommandLine.getInstance().appendSwitch(ContentSwitches.ENABLE_CREDENTIAL_MANAGER_API);
}
/**
@@ -77,4 +81,61 @@ public class SavedPasswordsPreferencesTest extends ChromeShellTestBase {
}
});
}
+
+ /**
+ * Ensure that the "Auto Sign-in" switch in "Save Passwords" settings actually enables and
+ * disables auto sign-in.
+ */
+ @SmallTest
+ @Feature({"Preferences"})
+ public void testAutoSignInCheckbox() throws Exception {
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ @Override
+ public void run() {
+ PrefServiceBridge.getInstance().setPasswordManagerAutoSigninEnabled(true);
+ }
+ });
+
+ final Preferences preferences = PreferencesTest.startPreferences(
+ getInstrumentation(), ManageSavedPasswordsPreferences.class.getName());
+
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ @Override
+ public void run() {
+ assertTrue(CommandLine.getInstance().hasSwitch(
+ ContentSwitches.ENABLE_CREDENTIAL_MANAGER_API));
+ ManageSavedPasswordsPreferences passwordPrefs =
+ (ManageSavedPasswordsPreferences) preferences.getFragmentForTest();
+ ChromeBaseCheckBoxPreference onOffSwitch =
+ (ChromeBaseCheckBoxPreference) passwordPrefs.findPreference(
+ ManageSavedPasswordsPreferences.PREF_AUTOSIGNIN_SWITCH);
+ assertTrue(onOffSwitch.isChecked());
+
+ PreferencesTest.clickPreference(passwordPrefs, onOffSwitch);
+ assertFalse(PrefServiceBridge.getInstance().isPasswordManagerAutoSigninEnabled());
+ PreferencesTest.clickPreference(passwordPrefs, onOffSwitch);
+ assertTrue(PrefServiceBridge.getInstance().isPasswordManagerAutoSigninEnabled());
+
+ preferences.finish();
+
+ PrefServiceBridge.getInstance().setPasswordManagerAutoSigninEnabled(false);
+ }
+ });
+
+ final Preferences preferences2 = PreferencesTest.startPreferences(
+ getInstrumentation(), ManageSavedPasswordsPreferences.class.getName());
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ @Override
+ public void run() {
+ assertTrue(CommandLine.getInstance().hasSwitch(
+ ContentSwitches.ENABLE_CREDENTIAL_MANAGER_API));
+ ManageSavedPasswordsPreferences passwordPrefs =
+ (ManageSavedPasswordsPreferences) preferences2.getFragmentForTest();
+ ChromeBaseCheckBoxPreference onOffSwitch =
+ (ChromeBaseCheckBoxPreference) passwordPrefs.findPreference(
+ ManageSavedPasswordsPreferences.PREF_AUTOSIGNIN_SWITCH);
+ assertFalse(onOffSwitch.isChecked());
+ }
+ });
+ }
}
« no previous file with comments | « chrome/android/java/strings/android_chrome_strings.grd ('k') | chrome/browser/android/preferences/pref_service_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698