Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 978883007: util/mac: Provide wrappers for <launch.h> functions deprecated in 10.10 (#3) (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

util/mac: Provide wrappers for <launch.h> functions deprecated in 10.10. A few stragglers were missing from bc401f6aac22. I really don’t know how that’s possible, since I thought I was testing it with the correct SDK. I guess I wasn’t. BUG=crashpad:11 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/88690cece30861e1697c0e6d1ecccbc50dffecf9

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M util/mac/service_management.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-07 03:42:41 UTC) #2
Robert Sesek
lgtm
5 years, 9 months ago (2015-03-08 03:31:45 UTC) #3
Mark Mentovai
5 years, 9 months ago (2015-03-08 19:12:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
88690cece30861e1697c0e6d1ecccbc50dffecf9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698