Issue 978773002: Remove default value for number of threads in Isolate::Init.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 978773002: Remove default value for number of threads in Isolate::Init. (Closed)

Created:
5 years, 9 months ago by Yang

Modified:
5 years, 9 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove default value for number of threads in Isolate::Init. Just fixing a TODO. R=jochen@chromium.org Committed: https://crrev.com/fbcebbc5bdfd8eed82d121faf07b536eb3142fb7 Cr-Commit-Position: refs/heads/master@{#26987}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	src/isolate.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978773002/1

5 years, 9 months ago (2015-03-04 13:41:27 UTC) #4

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/fbcebbc5bdfd8eed82d121faf07b536eb3142fb7 Cr-Commit-Position: refs/heads/master@{#26987}

5 years, 9 months ago (2015-03-04 14:08:47 UTC) #6

Yang

5 years, 9 months ago (2015-03-04 14:26:27 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/964743003/ by yangguo@chromium.org.

The reason for reverting is: build failures..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages