Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 978753002: Crash test for 400997. (Closed)

Created:
5 years, 9 months ago by rune
Modified:
5 years, 9 months ago
Reviewers:
keishi, tkent
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Crash test for 400997. Scrollbars can be kept alive referenced from the EventHandler after they have been detached from their ScrollableAreas (through m_lastScrollbarUnderMouse and m_scrollbarHandlingScrollGesture). EventHandler may call setHoveredPart and setPressedPart on custom scroll- bars (LayoutScrollbar) on mouse moves after these bars have been detached from their scrollable areas. Those methods recalculate style for custom scrollbar pseudo elements. That caused a crash in SelectorChecker for the :corner-present pseudo class because it used the scrollableArea() from Scrollbar without null-checking it. The null-check was added as a speculative fix in r191244. This CL adds a test which causes that crasher. R=keishi@chromium.org,tkent@chromium.org BUG=400997 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
A LayoutTests/fast/css/crash-corner-present.html View 1 chunk +47 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/crash-corner-present-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rune
PTAL
5 years, 9 months ago (2015-03-04 09:47:30 UTC) #1
keishi
Thanks! LGTM.
5 years, 9 months ago (2015-03-04 13:18:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978753002/1
5 years, 9 months ago (2015-03-04 13:22:12 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 13:25:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191278

Powered by Google App Engine
This is Rietveld 408576698