ninja/win: Support VCLinkerTool.GenerateManifest

ninja/win: Support VCLinkerTool.GenerateManifest

Currently Ninja generator always expects VCLinkerTool.GenerateManifest is true. With this CL, it will be configurable like MSVS generator.

BUG=gyp:389
TEST=python gyptest.py test/win/gyptest-link-generate-manifest.py
R=scottmg@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1802

[yukawa, 2013-12-02 17:05:52]

Hi,

Probably people rarely want to set false to VCLinkerTool.GenerateManifest but I
encountered this situation to work around a trybot failure of my pending PGO
patch.

https://codereview.chromium.org/82703007/
http://build.chromium.org/p/tryserver.nacl/builders/gyp-win32/builds/1462/ste...
> LINK : fatal error LNK1268: inconsistent option
>
'ManifestFile:obj\test_pgo_optimize.test_pgo_optimize.exe.intermediate.manifest'
> specified with /LTCG:PGOPTIMIZE but not with /LTCG:PGINSTRUMENT

Surprisingly, the linker is complaining that /ManifestFile:<filename> option is
changed between PGI build and PGO build.  Perhaps we can work around this with
explicitly specifying /ManifestFile option, but our Ninja generator does not
support VCLinkerTool.ManifestFile yet. Meanwhile, I'd like to disable manifest
file generation to make the test green before I submit that CL.

Sorry for introducing additional complexity to ninja.py for such a less
important configuration but I hope I did my best to keep it as simple as
possible.

[scottmg, 2013-12-02 18:17:56]

I haven't looked through the CL yet, but is it sufficient to use "EmbedManifest:
false" to avoid the PGI/PGO error?

[scottmg, 2013-12-02 18:46:39]

Unrelated to my other comment, this seems worth supporting. Thanks for doing
this!

LGTM

[yukawa, 2013-12-03 03:29:15]

On 2013/12/02 18:17:56, scottmg wrote:
> I haven't looked through the CL yet, but is it sufficient to use
"EmbedManifest:
> false" to avoid the PGI/PGO error?

Yes. The root cause is that our msvs_emulator always specified |'/ManifestFile:'
+ output_name| and we couldn't suppress that option.  With this CL,
msvs_emulator specifies /ManifestFile when and only when 'EmbedManifest' is
true.

[yukawa, 2013-12-03 14:33:06]

Committed patchset #1 manually as r1802.