Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 97863002: Roll Skia DEPS to r12430 (Closed)

Created:
7 years ago by robertphillips
Modified:
7 years ago
Reviewers:
bsalomon, rmistry, reed1
CC:
chromium-reviews, skia-team_google.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix NEON path #

Patch Set 3 : Roll forward to fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M DEPS View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M skia/skia_library_opts.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
control: https://codereview.chromium.org/97393003/
7 years ago (2013-12-01 13:57:47 UTC) #1
robertphillips
This is still broken on Windows and Mac (suspect 8->1 conversion resulting from A1 removal). ...
7 years ago (2013-12-02 13:04:02 UTC) #2
robertphillips
The Windows and Mac layout test failures should be fixed by Skia r12430 (https://codereview.chromium.org/99323002/)
7 years ago (2013-12-02 15:51:19 UTC) #3
robertphillips
We have green on mac_layout_rel so I think we are good to go.
7 years ago (2013-12-02 16:43:36 UTC) #4
bsalomon
On 2013/12/02 16:43:36, robertphillips wrote: > We have green on mac_layout_rel so I think we ...
7 years ago (2013-12-02 16:46:14 UTC) #5
robertphillips
7 years ago (2013-12-02 16:46:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r238118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698