Source/core/layout/LayoutBlock.cpp - Issue 978603003: [New Multicolumn] Make positionForPoint() work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlock.cpp

Issue 978603003: [New Multicolumn] Make positionForPoint() work. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: code review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: Source/core/layout/LayoutBlock.cpp

diff --git a/Source/core/layout/LayoutBlock.cpp b/Source/core/layout/LayoutBlock.cpp

index e38851d655af255011609b8799efe187544aa56e..8c6177a60d582204fd9935744d0360c559d24a9e 100644

--- a/Source/core/layout/LayoutBlock.cpp

+++ b/Source/core/layout/LayoutBlock.cpp

@@ -2518,7 +2518,7 @@ PositionWithAffinity LayoutBlock::positionForPointWithInlineChildren(const Layou

static inline bool isChildHitTestCandidate(LayoutBox* box)

{

- return box->size().height() && box->style()->visibility() == VISIBLE && !box->isFloatingOrOutOfFlowPositioned();

+ return box->size().height() && box->style()->visibility() == VISIBLE && !box->isFloatingOrOutOfFlowPositioned() && !box->isLayoutFlowThread();

}

PositionWithAffinity LayoutBlock::positionForPoint(const LayoutPoint& point)