LayoutTests/fast/multicol/caret-range-outside-columns.html - Issue 978603003: [New Multicolumn] Make positionForPoint() work.

Side by Side Diff: LayoutTests/fast/multicol/caret-range-outside-columns.html

Issue 978603003: [New Multicolumn] Make positionForPoint() work. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: code review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/multicol/caret-range-outside-columns-expected.txt » ('j') | LayoutTests/fast/pagination/caret-range-outside-paged-y.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 body { margin:0; }

	4 #mc { -webkit-columns:3; -webkit-column-gap:20px; width:280px; margin:20px 1 00px; font:20px/1 Ahem; }
	Julien - ping for review 2015/03/12 14:13:00 We don't have an explicit coding style for tests b We don't have an explicit coding style for tests but we usually follow Blink style. This means that we prefer one statement per line. As this is not strictly enforced, it's a nit. mstensho (USE GERRIT) 2015/03/13 09:34:19 Done. Show quoted text On 2015/03/12 14:13:00, Julien Chaffraix - PST wrote: > We don't have an explicit coding style for tests but we usually follow Blink > style. This means that we prefer one statement per line. As this is not strictly > enforced, it's a nit. Done.
	5

	6 /* We don't want the log to get too close to the multicol container, or the tests might fail. */
	Julien - ping for review 2015/03/12 14:13:00 I don't think I understand that: the log is absolu I don't think I understand that: the log is absolutely positioned so it shouldn't impact the multi-column container. mstensho (USE GERRIT) 2015/03/13 09:34:19 OK, I'll position it at top:101px instead. The low Show quoted text On 2015/03/12 14:13:00, Julien Chaffraix - PST wrote: > I don't think I understand that: the log is absolutely positioned so it > shouldn't impact the multi-column container. OK, I'll position it at top:101px instead. The lowest coordinate we test is 100px.
	7 #log { position:absolute; top:50%; }

	8 </style>

	9 <body>
	Julien - ping for review 2015/03/12 14:13:00 No need for <body> No need for <body> mstensho (USE GERRIT) 2015/03/13 09:34:19 Done. Show quoted text On 2015/03/12 14:13:00, Julien Chaffraix - PST wrote: > No need for <body> Done.
	10 <div id="log">

	11 <p id="description"></p>

	12 <div id="console"></div>

	13 </div>

	14 <div id="mc">xxx xxx xxx xxx xxx xxx xxx xxx xxx</div>

	15 <script src="../../resources/js-test.js"></script>

	16 <script>

	17 description("Test that hitting areas outside columns takes us to the rig ht text content inside columns.");

	18

	19 // Above first column
	Julien - ping for review 2015/03/12 14:13:00 This looks like it should be dumped into the outpu This looks like it should be dumped into the output as it's relevant to read it. mstensho (USE GERRIT) 2015/03/13 09:34:19 Done. Show quoted text On 2015/03/12 14:13:00, Julien Chaffraix - PST wrote: > This looks like it should be dumped into the output as it's relevant to read it. Done.
	20 shouldBe("document.caretRangeFromPoint(50,0).startOffset", "0");

	21 shouldBe("document.caretRangeFromPoint(150,0).startOffset", "0");

	22 shouldBe("document.caretRangeFromPoint(189,0).startOffset", "0");

	23

	24 // Above second column

	25 shouldBe("document.caretRangeFromPoint(190,0).startOffset", "12");

	26 shouldBe("document.caretRangeFromPoint(250,0).startOffset", "12");

	27 shouldBe("document.caretRangeFromPoint(289,0).startOffset", "12");

	28

	29 // Above third column

	30 shouldBe("document.caretRangeFromPoint(290,0).startOffset", "24");

	31 shouldBe("document.caretRangeFromPoint(350,0).startOffset", "24");

	32 shouldBe("document.caretRangeFromPoint(450,0).startOffset", "24");

	33

	34 // Below first column

	35 shouldBe("document.caretRangeFromPoint(50,100).startOffset", "12");

	36 shouldBe("document.caretRangeFromPoint(150,100).startOffset", "12");

	37 shouldBe("document.caretRangeFromPoint(189,100).startOffset", "12");

	38

	39 // Below second column

	40 shouldBe("document.caretRangeFromPoint(190,100).startOffset", "24");

	41 shouldBe("document.caretRangeFromPoint(250,100).startOffset", "24");

	42 shouldBe("document.caretRangeFromPoint(289,100).startOffset", "24");

	43

	44 // To the left of the first column

	45 shouldBe("document.caretRangeFromPoint(0,10).startOffset", "0");

	46 shouldBe("document.caretRangeFromPoint(0,30).startOffset", "0");

	47 shouldBe("document.caretRangeFromPoint(0,50).startOffset", "4");

	48 shouldBe("document.caretRangeFromPoint(0,70).startOffset", "8");

	49 shouldBe("document.caretRangeFromPoint(0,90).startOffset", "12");

	50

	51 // To the right of the third column

	52 shouldBe("document.caretRangeFromPoint(400,10).startOffset", "24");

	53 shouldBe("document.caretRangeFromPoint(400,30).startOffset", "27");

	54 shouldBe("document.caretRangeFromPoint(400,50).startOffset", "31");

	55 shouldBe("document.caretRangeFromPoint(400,70).startOffset", "35");

	56

	57 // In the gap between the first and second columns

	58 shouldBe("document.caretRangeFromPoint(180,20).startOffset", "3");

	59 shouldBe("document.caretRangeFromPoint(180,40).startOffset", "7");

	60 shouldBe("document.caretRangeFromPoint(180,60).startOffset", "11");

	61 shouldBe("document.caretRangeFromPoint(180,69).startOffset", "11");

	62

	63 // In the gap between the second and third columns

	64 shouldBe("document.caretRangeFromPoint(280,20).startOffset", "15");

	65 shouldBe("document.caretRangeFromPoint(280,40).startOffset", "19");

	66 shouldBe("document.caretRangeFromPoint(280,60).startOffset", "23");

	67 shouldBe("document.caretRangeFromPoint(280,69).startOffset", "23");

	68 </script>

	69 </body>

OLD	NEW