Issue 978603002: Fixes ViewManagerClient name in sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 978603002: Fixes ViewManagerClient name in sky (Closed)

Created:
5 years, 9 months ago by sky

Modified:
5 years, 9 months ago

Reviewers:
hansmuller, hansmuller1, abarth-chromium

CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fixes ViewManagerClient name in sky It needs to be mojo::ViewManagerClient; none-the-less we should use the value from the header so we're insulated from whatever the name happens to be. R=hansmuller@google.com, abarth@chromium.org, hansmuller@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0737f532f967c91d5b644d66a1514cee140f8940

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	sky/viewer/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	sky/viewer/document_view.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

sky

5 years, 9 months ago (2015-03-03 22:03:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0737f532f967c91d5b644d66a1514cee140f8940 (presubmit successful).