Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 978523002: Replace usage of cloud_storage in archive_info_unittest. (Closed)

Created:
5 years, 9 months ago by aiolos (Not reviewing)
Modified:
5 years, 9 months ago
Reviewers:
nednguyen, dtu, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace usage of cloud_storage in archive_info_unittest. Committed: https://crrev.com/232dd27a41fe41c2fe3fb772b7cab04bba4d92da Cr-Commit-Position: refs/heads/master@{#319369}

Patch Set 1 #

Patch Set 2 : replace CS usage in two more functions #

Total comments: 3

Patch Set 3 : Refactor unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -19 lines) Patch
M tools/telemetry/telemetry/wpr/archive_info_unittest.py View 1 2 5 chunks +37 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
aiolos (Not reviewing)
5 years, 9 months ago (2015-03-04 00:59:32 UTC) #2
sullivan
lgtm https://codereview.chromium.org/978523002/diff/20001/tools/telemetry/telemetry/wpr/archive_info_unittest.py File tools/telemetry/telemetry/wpr/archive_info_unittest.py (right): https://codereview.chromium.org/978523002/diff/20001/tools/telemetry/telemetry/wpr/archive_info_unittest.py#newcode109 tools/telemetry/telemetry/wpr/archive_info_unittest.py:109: stubs = system_stub.Override(archive_info, ['cloud_storage']) Any reason not to ...
5 years, 9 months ago (2015-03-04 14:24:10 UTC) #3
nednguyen
lgtm with Annie's comment.
5 years, 9 months ago (2015-03-04 15:55:42 UTC) #4
aiolos (Not reviewing)
https://codereview.chromium.org/978523002/diff/20001/tools/telemetry/telemetry/wpr/archive_info_unittest.py File tools/telemetry/telemetry/wpr/archive_info_unittest.py (right): https://codereview.chromium.org/978523002/diff/20001/tools/telemetry/telemetry/wpr/archive_info_unittest.py#newcode109 tools/telemetry/telemetry/wpr/archive_info_unittest.py:109: stubs = system_stub.Override(archive_info, ['cloud_storage']) On 2015/03/04 14:24:10, sullivan wrote: ...
5 years, 9 months ago (2015-03-04 23:54:53 UTC) #5
sullivan
lgtm lgtm again
5 years, 9 months ago (2015-03-05 22:54:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978523002/40001
5 years, 9 months ago (2015-03-05 22:55:47 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-05 23:57:17 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 23:58:02 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/232dd27a41fe41c2fe3fb772b7cab04bba4d92da
Cr-Commit-Position: refs/heads/master@{#319369}

Powered by Google App Engine
This is Rietveld 408576698