minidump: Reorganize MinidumpModuleCrashpadInfo to improve linking between structures

minidump: Reorganize MinidumpModuleCrashpadInfo to improve linking
between classic and extension structures.

Previosly, each MinidumpModuleCrashpadInfo structure contained a
minidump_module_list_index field referencing a module in the
MINIDUMP_MODULE_LIST stream by index. This layout was discovered to
cause a problem for the new minidump reader in ModuleSnapshotMinidump.
Instead, the module list index for linkage should be contained in the
MinidumpModuleCrashpadInfoList alongside the LOCATION_DESCRIPTORs
pointing to each MinidumpModuleCrashpadInfo.

The organizational difference is small, but this enables a better design
for ModuleSnapshotMinidump. When initializing a ModuleSnapshotMinidump
with the new layout, it is possible for the caller to have access to the
location descriptor for the MinidumpModuleCrashpadInfo corresponding to
a MINIDUMP_MODULE_LIST. Previously, the caller would not have had this
data without interpreting each MinidumpModuleCrashpadInfo, which
ModuleSnapshotMinidump would have to do anyway.

MinidumpModuleCrashpadInfoListWriter was the only user of
MinidumpLocationDescriptorListWriter, which is obsoleted and removed in
this change. Its functionality is moving directly into
MinidumpModuleCrashpadInfoListWriter, but it is no longer generic enough
to maintain as a distinct class.

TEST=minidump_test \
     MinidumpModuleCrashpadInfoWriter.*,MinidumpCrashpadInfoWriter.*

R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4539fd1553d43ff2c754d84af45c2e5040d0f0c2

[Mark Mentovai, 2015-03-03 20:07:16]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2015-03-04 00:17:39]

LGTM. Yes this is much cleaner.

[Mark Mentovai, 2015-03-04 15:53:57]

Committed patchset #2 (id:20001) manually as
4539fd1553d43ff2c754d84af45c2e5040d0f0c2 (presubmit successful).