Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 978443002: Revert of XPS, DM: add SkDocument::CreateXPS (Closed)

Created:
5 years, 9 months ago by hal.canary
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of XPS, DM: add SkDocument::CreateXPS (patchset #8 id:310001 of https://codereview.chromium.org/963953002/) Reason for revert: breaking iOS build. Original issue's description: > XPS, DM: add SkDocument::CreateXPS > > - SkDocument::CreateXPS() function added, returns NULL on non-Windows OS. > > - DM: (Windows only) an XPSSink is added, fails on non-Windows OS > > - DM: Common code for PDFSink::draw and XPSSink::draw are factored into > draw_skdocument static function. > > - SkDocument_XPS (Windows only) implementation of SkDocument via > SkXPSDevice. > > - SkDocument_XPS_None (non-Windows) returns NULL for > SkDocument::CreateXPS(). > > - gyp/xps.gyp refactored. > > - SkXPSDevice::drawTextOnPath removed (see http://crrev.com/925343003 ) > > - SkXPSDevice::drawPath supports conics via SkAutoConicToQuads. > > NOPRESUBMIT=true > > Committed: https://skia.googlesource.com/skia/+/00d39bcbfc8394a9b48b86b04ab06ec19091fa43 TBR=reed@google.com,bungeman@google.com,mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/c2574f3657b1359496a4eba5b191961974b3a64f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -175 lines) Patch
M dm/DM.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M dm/DMSrcSink.h View 1 chunk +0 lines, -9 lines 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +6 lines, -24 lines 0 comments Download
M gyp/dm.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/xps.gyp View 1 chunk +39 lines, -26 lines 0 comments Download
M include/core/SkDocument.h View 1 chunk +0 lines, -13 lines 0 comments Download
M include/device/xps/SkXPSDevice.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 4 chunks +8 lines, -18 lines 0 comments Download
D src/doc/SkDocument_XPS.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D src/doc/SkDocument_XPS_None.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hal.canary
Created Revert of XPS, DM: add SkDocument::CreateXPS
5 years, 9 months ago (2015-03-03 16:33:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978443002/1
5 years, 9 months ago (2015-03-03 16:34:08 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 16:34:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c2574f3657b1359496a4eba5b191961974b3a64f

Powered by Google App Engine
This is Rietveld 408576698