DM: Use the new non-fatal errors for invalid color conversions.

DM: Use the new non-fatal errors for invalid color conversions.

Also allow incomplete to be considered successful.

Do not attempt to draw transparent images on 565.

BUG=skia:3475
Committed: https://skia.googlesource.com/skia/+/56e25ddf6e2c1f85c5addbe498a082268ebee6ea

[mtklein, 2015-03-05 17:06:29]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-03-05 17:06:30]

lgtm

[mtklein, 2015-03-05 17:07:36]

https://codereview.chromium.org/978413002/diff/20001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/978413002/diff/20001/dm/DMSrcSink.cpp#newcode92
dm/DMSrcSink.cpp:92: return Error::Nonfatal("Skipping drawing non-opaque image
to opaque dst.");
we're going to add "skipped: " to the front of this, so you might want to drop
"Skipping".

[scroggo, 2015-03-05 19:34:24]

scroggo@google.com changed reviewers:
+ msarett@google.com

[scroggo, 2015-03-05 19:34:24]

Matt: FYI, this updates DM to support incomplete images.

https://codereview.chromium.org/978413002/diff/20001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/978413002/diff/20001/dm/DMSrcSink.cpp#newcode92
dm/DMSrcSink.cpp:92: return Error::Nonfatal("Skipping drawing non-opaque image
to opaque dst.");
On 2015/03/05 17:07:36, mtklein wrote:
> we're going to add "skipped: " to the front of this, so you might want to drop
> "Skipping".

Done.

[scroggo, 2015-03-05 19:34:29]

The CQ bit was checked by scroggo@google.com

[scroggo, 2015-03-05 19:34:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/978413002/#ps40001 (title:
"Update nonfatal error message.")

[commit-bot: I haz the power, 2015-03-05 19:35:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/978413002/40001

[commit-bot: I haz the power, 2015-03-05 19:46:43]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/56e25ddf6e2c1f85c5addbe498a082268ebee6ea