Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 978363002: Update gpu trace marker system for MultiDrawBuffer world (Closed)

Created:
5 years, 9 months ago by robertphillips
Modified:
5 years, 9 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update gpu trace marker system for MultiDrawBuffer world The main thrust of this CL is to remove the currCmdMarker variable from GrTargetCommands::flush. In a MultiDrawBuffer world the Cmds need not be execute in the order of their issuance. Committed: https://skia.googlesource.com/skia/+/bca3c9fb2d5c043985b878633e9630cf12e04bd6

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : More clean up #

Patch Set 4 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -53 lines) Patch
M src/gpu/GrInOrderDrawBuffer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrTargetCommands.h View 1 10 chunks +32 lines, -27 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 2 3 6 chunks +18 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
robertphillips
5 years, 9 months ago (2015-03-05 15:37:07 UTC) #2
robertphillips
Updated for https://codereview.chromium.org/981973002/ (Fix GPU trace marker bug) and successfully tested.
5 years, 9 months ago (2015-03-05 16:59:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978363002/60001
5 years, 9 months ago (2015-03-05 17:01:44 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-05 17:01:44 UTC) #6
egdaniel
lgtm
5 years, 9 months ago (2015-03-05 17:03:58 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 17:17:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/bca3c9fb2d5c043985b878633e9630cf12e04bd6

Powered by Google App Engine
This is Rietveld 408576698