Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 978353002: Add [TypeChecking=Unrestricted] to SubtleCrypto interface (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
eroman
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add [TypeChecking=Unrestricted] to SubtleCrypto interface This only changes the error messages of the TypeError exceptions thrown. Also clean up C++-side error handling, some of which was already unnecessary. BUG=462561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -91 lines) Patch
M LayoutTests/crypto/subtle/aes-export-key-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/crypto/subtle/exportKey-badParameters-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/crypto/subtle/unwrapKey-badParameters.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/crypto/subtle/unwrapKey-badParameters-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/crypto/subtle/wrapKey-badParameters-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.cpp View 12 chunks +0 lines, -80 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-03-05 14:45:08 UTC) #2
eroman
LGTM. Excellent, thanks!
5 years, 9 months ago (2015-03-05 19:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978353002/1
5 years, 9 months ago (2015-03-05 19:09:39 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 20:30:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191380

Powered by Google App Engine
This is Rietveld 408576698