Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 978273002: Make user pod menu always visible in touchview mode (Closed)

Created:
5 years, 9 months ago by Dmitry Polukhin
Modified:
5 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make user pod menu always visible in touchview mode BUG=454505 TEST=manual Committed: https://crrev.com/bc6ca96ee7b2f83a4ffd634c7b48dc8a3ebdc7ad Cr-Commit-Position: refs/heads/master@{#319861}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M ui/login/account_picker/user_pod_row.css View 1 chunk +2 lines, -1 line 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dmitry Polukhin
5 years, 9 months ago (2015-03-05 12:47:24 UTC) #2
Nikita (slow)
lgtm https://codereview.chromium.org/978273002/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/978273002/diff/1/ui/login/account_picker/user_pod_row.js#newcode2141 ui/login/account_picker/user_pod_row.js:2141: // If we're in touch Touch View mode. ...
5 years, 9 months ago (2015-03-10 09:50:42 UTC) #3
Dmitry Polukhin
5 years, 9 months ago (2015-03-10 10:43:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978273002/20001
5 years, 9 months ago (2015-03-10 10:44:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 11:47:55 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 11:48:20 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bc6ca96ee7b2f83a4ffd634c7b48dc8a3ebdc7ad
Cr-Commit-Position: refs/heads/master@{#319861}

Powered by Google App Engine
This is Rietveld 408576698