bindings,devtools: Shows DOM attributes' values in DevTools.

Source/core/inspector/InjectedScriptSource.js

Index: Source/core/inspector/InjectedScriptSource.js
diff --git a/Source/core/inspector/InjectedScriptSource.js b/Source/core/inspector/InjectedScriptSource.js
index 234c0a831a3eb73c6ac57de6a3ba89256daebddb..0b454f1b96f9e346bb86e16e30e442e397763ee5 100644
--- a/Source/core/inspector/InjectedScriptSource.js
+++ b/Source/core/inspector/InjectedScriptSource.js
@@ -555,7 +555,7 @@ InjectedScript.prototype = {
                     if (descriptor) {
                         if (accessorPropertiesOnly && !("get" in descriptor || "set" in descriptor))
                             continue;
-                        if ("get" in descriptor && "set" in descriptor && InjectedScriptHost.isPopularDOMObject(object) && name != "__proto__") {
+                        if ("get" in descriptor && "set" in descriptor && name != "__proto__" && InjectedScriptHost.isDOMAttributeWithNoSideEffect(object, name)) {

[haraken, 2015/03/05 15:14:26]

If pfeldman@ is fine, IMHO, we should do the blacklisting in JS instead of C++,
because JS-side blacklisting would be much simpler and thus safer (this CL
introduces a bunch of complicated logic to C++). For example, we can create a
helper function like:

  function isDOMAttributeWithNoSideEffect(object, name) {
    if (object instanceof Request && name == "body")
      return false;
    if (object instanceof Response && name == "body")
      return false;
    return true;
  }

If it is not acceptable, I'm OK with the current approach.

[pfeldman, 2015/03/05 17:42:54]

I'm fine with it as long as the instanceof Request / Response is implemented in
the bindings.

[haraken, 2015/03/06 02:29:19]

If we want to implement the instanceof Request/Response in bindings/, we need to
implement it in C++, resulting in this CL...

One way to avoid the complexity would be to implement
InjectedScriptHost.isDOMAttributeWithNoSideEffect in Blink-in-JS. Then we can
put it in bindings/ but can write the logic in JS. This might be worth doing,
because we can move a lot of complicated existing C++ in
V8InjectedScriptHostCustom.cpp to the JS as well.

Jens?

                             descriptor.value = InjectedScriptHost.suppressWarningsAndCallFunction(function(attribute) { return this[attribute]; }, object, [name]);
                             delete descriptor.get;
                             delete descriptor.set;