Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: Source/bindings/core/v8/V8Binding.h

Issue 978233002: bindings,devtools: Shows DOM attributes' values in DevTools. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8Binding.cpp » ('j') | Source/core/inspector/InjectedScriptSource.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8Binding.h
diff --git a/Source/bindings/core/v8/V8Binding.h b/Source/bindings/core/v8/V8Binding.h
index c106cb10058766f72ffce025bec427b936906da2..94b99472b0a0ebaa4d2b77650680307c57d59d4b 100644
--- a/Source/bindings/core/v8/V8Binding.h
+++ b/Source/bindings/core/v8/V8Binding.h
@@ -995,6 +995,21 @@ private:
PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(v8::Isolate*, ExecutionContext*, v8::Handle<v8::Function>);
+class AttributesWithObservableSideEffectOnGet final {
+public:
+ // Returns true iff |domObject| is a DOM object and whose attribute named
+ // |attributeName| has no observable side effect when "get" is called.
+ static bool hasNoSideEffect(v8::Isolate*, v8::Handle<v8::Value> domObject, v8::Handle<v8::Value> attributeName);
+
+ // Registers a DOM attribute which has side effect when "get" is called.
+ static void add(const WrapperTypeInfo*, String attributeName);
+
+private:
+ typedef Vector<std::pair<const WrapperTypeInfo*, String>> AttributeSet;
+
+ static AttributeSet* attributesWithSideEffectOnGet();
+};
+
class V8RethrowTryCatchScope final {
public:
explicit V8RethrowTryCatchScope(v8::TryCatch& block) : m_block(block) { }
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8Binding.cpp » ('j') | Source/core/inspector/InjectedScriptSource.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698