Issue 978213002: Implement ErrorScreenHandler::Hide method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 978213002: Implement ErrorScreenHandler::Hide method (Closed)

Created:
5 years, 9 months ago by Dmitry Polukhin

Modified:
5 years, 9 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Implement ErrorScreenHandler::Hide method It is trivial naive implementation but it seems sufficient and it works. BUG=462453 TEST=manually

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nikita (slow)

5 years, 9 months ago (2015-03-05 10:54:10 UTC) #3

lgtm

I've looked into refactoring CL that caused this regression:
https://codereview.chromium.org/872633008/

I can confirm that handler should be just delegating actions to model.
ErrorScreen::OnHide() includes code that changes CP detection strategy +
executes on_hide_callback.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages