CpuProfiler: simplify test.

CpuProfiler: simplify test.

BUG=
LOG=n
TBR=yurys, svenpanne

Committed: https://crrev.com/5cd7707c55dd4fa6c359ec835c315d0bac4bc2b2
Cr-Commit-Position: refs/heads/master@{#27008}

[loislo, 2015-03-05 09:47:42]

The CQ bit was checked by loislo@chromium.org

[commit-bot: I haz the power, 2015-03-05 09:48:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/978203002/1

[yurys, 2015-03-05 09:56:07]

lgtm,

but would it be possible to first enable these tests?

https://codereview.chromium.org/978203002/diff/1/test/cctest/test-cpu-profile...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/978203002/diff/1/test/cctest/test-cpu-profile...
test/cctest/test-cpu-profiler.cc:59: static const char* reason(const
i::Deoptimizer::DeoptReason reason) {
style nit: GetReason but I'd rather you kept it inline for better readability.

https://codereview.chromium.org/978203002/diff/1/test/cctest/test-cpu-profile...
test/cctest/test-cpu-profiler.cc:502: for (int i = 0; i < length; i++) node =
GetChild(node, names[i]);
please use {}

[loislo, 2015-03-05 09:58:56]

The CQ bit was unchecked by loislo@chromium.org

[loislo, 2015-03-05 10:04:46]

https://codereview.chromium.org/978203002/diff/1/test/cctest/test-cpu-profile...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/978203002/diff/1/test/cctest/test-cpu-profile...
test/cctest/test-cpu-profiler.cc:59: static const char* reason(const
i::Deoptimizer::DeoptReason reason) {
On 2015/03/05 09:56:07, yurys wrote:
> style nit: GetReason but I'd rather you kept it inline for better readability.

I don't see that it becomes less readable.
Also the function has no logic inside.
And the reason was to make the checks less wordy.

https://codereview.chromium.org/978203002/diff/1/test/cctest/test-cpu-profile...
test/cctest/test-cpu-profiler.cc:502: for (int i = 0; i < length; i++) node =
GetChild(node, names[i]);
On 2015/03/05 09:56:07, yurys wrote:
> please use {}

Done.

[loislo, 2015-03-05 10:05:57]

The CQ bit was checked by loislo@chromium.org

[loislo, 2015-03-05 10:05:57]

The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/978203002/#ps20001 (title:
"comments addressed")

[commit-bot: I haz the power, 2015-03-05 10:06:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/978203002/20001

[commit-bot: I haz the power, 2015-03-05 10:38:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-05 10:38:17]

Patchset 2 (id:??) landed as
https://crrev.com/5cd7707c55dd4fa6c359ec835c315d0bac4bc2b2
Cr-Commit-Position: refs/heads/master@{#27008}