Fix glGetActiveUniform/Attrib crashes due to state inconsistency

Fix glGetActiveUniform/Attrib crashes due to state inconsistency

between what Chrome thinks and what the driver is.

This is caused by we intercept invalid program and generate an error on
LinkProgram rather than passing it to the driver, so the driver still have
a valid program if the previous link succeeds.

BUG=463599
TEST=test case in the bug
R=sievers@chromium.org

Committed: https://crrev.com/44ad5ecc3abf8f31d7e55a9ece5cea30a710fd77
Cr-Commit-Position: refs/heads/master@{#319746}

[Zhenyao Mo, 2015-03-07 01:00:08]

zmo@chromium.org changed reviewers:
+ kbr@chromium.org, piman@chromium.org

[Zhenyao Mo, 2015-03-07 01:00:08]

Please take a look.

This is not the right fix, but the minimum fix I can come up with, so merging to
previous releases is easy.

I will fix it appropriately once this lands.

https://codereview.chromium.org/978193003/diff/1/gpu/blink/webgraphicscontext...
File gpu/blink/webgraphicscontext3d_impl.cc (left):

https://codereview.chromium.org/978193003/diff/1/gpu/blink/webgraphicscontext...
gpu/blink/webgraphicscontext3d_impl.cc:366: synthesizeGLError(GL_OUT_OF_MEMORY);
This is unnecessary because we always crash when "new" fails.

[Ken Russell (switch to Gerrit), 2015-03-07 02:21:12]

LGTM as a short-term fix.

[no sievers, 2015-03-09 19:10:08]

https://codereview.chromium.org/978193003/diff/1/gpu/blink/webgraphicscontext...
File gpu/blink/webgraphicscontext3d_impl.cc (right):

https://codereview.chromium.org/978193003/diff/1/gpu/blink/webgraphicscontext...
gpu/blink/webgraphicscontext3d_impl.cc:366: synthesizeGLError(GL_INVALID_VALUE);
This seems correct if the program is not valid. But what if the linked shader is
valid but does not reference any attributes or uniforms?

[no sievers, 2015-03-09 19:13:54]

https://codereview.chromium.org/978193003/diff/1/gpu/blink/webgraphicscontext...
File gpu/blink/webgraphicscontext3d_impl.cc (right):

https://codereview.chromium.org/978193003/diff/1/gpu/blink/webgraphicscontext...
gpu/blink/webgraphicscontext3d_impl.cc:366: synthesizeGLError(GL_INVALID_VALUE);
On 2015/03/09 19:10:08, sievers wrote:
> This seems correct if the program is not valid. But what if the linked shader
is
> valid but does not reference any attributes or uniforms?

nm, we do call getProgramiv() but this is obviously the right error for
getActiveAttrib/Uniform then too.

lgtm

[Zhenyao Mo, 2015-03-09 19:58:28]

https://codereview.chromium.org/978193003/diff/1/gpu/blink/webgraphicscontext...
File gpu/blink/webgraphicscontext3d_impl.cc (right):

https://codereview.chromium.org/978193003/diff/1/gpu/blink/webgraphicscontext...
gpu/blink/webgraphicscontext3d_impl.cc:366: synthesizeGLError(GL_INVALID_VALUE);
If the linked program has zero attribs or uniforms, then no matter what the
index value is, it is wrong, so an INVALID_VALUE is guaranteed.

[Zhenyao Mo, 2015-03-09 19:58:37]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2015-03-09 19:59:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/978193003/1

[commit-bot: I haz the power, 2015-03-09 22:13:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-09 22:13:57]

Patchset 1 (id:??) landed as
https://crrev.com/44ad5ecc3abf8f31d7e55a9ece5cea30a710fd77
Cr-Commit-Position: refs/heads/master@{#319746}