Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 978183002: X87: Refactor BreakLocationIterator (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Refactor BreakLocationIterator port 1a608493e55eacf5c7569e2b1213da42eb0e6207 (r26983) original commit message: Refactor BreakLocationIterator. We now have BreakLocation::Iterator to iterate via RelocIterator, and create a BreakLocation when we are done iterating. The reloc info is stored in BreakLocation in a GC-safe way and instantiated on demand. BUG= Committed: https://crrev.com/7f78e7b34782abefec152752a5475ac403857f48 Cr-Commit-Position: refs/heads/master@{#27003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M src/x87/assembler-x87.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M src/x87/debug-x87.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-03-05 02:45:35 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-03-05 05:18:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978183002/1
5 years, 9 months ago (2015-03-05 05:19:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 05:41:01 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 05:41:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f78e7b34782abefec152752a5475ac403857f48
Cr-Commit-Position: refs/heads/master@{#27003}

Powered by Google App Engine
This is Rietveld 408576698