Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 978133002: Revert of Use tiles when encoding with VP9. (Closed)

Created:
5 years, 9 months ago by aconverse
Modified:
5 years, 9 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use tiles when encoding with VP9. (patchset #1 id:1 of https://codereview.chromium.org/977663004/) Reason for revert: Breaks linux valgrind, needs libvpx side fixes and roll, http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/44420 Original issue's description: > Use tiles when encoding with VP9. > > VP9's tile encoding feature allows for multithreaded parallelism on both the > encoder and decoder side. > > TEST=Run remoting_perftests under VTune and see that two logical CPUs are used > BUG=134202 > > Committed: https://crrev.com/e67fefbf4f5a5a83ca8d487f422b09664dc4c8fe > Cr-Commit-Position: refs/heads/master@{#319167} TBR=wez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=134202 Committed: https://crrev.com/6d0e2690d8a1352f48daea52574aba0d1c0f51bd Cr-Commit-Position: refs/heads/master@{#319185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M remoting/codec/video_encoder_vpx.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aconverse
Created Revert of Use tiles when encoding with VP9.
5 years, 9 months ago (2015-03-05 01:05:10 UTC) #1
Wez
lgtm
5 years, 9 months ago (2015-03-05 01:05:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978133002/1
5 years, 9 months ago (2015-03-05 01:06:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 01:07:42 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 01:08:19 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d0e2690d8a1352f48daea52574aba0d1c0f51bd
Cr-Commit-Position: refs/heads/master@{#319185}

Powered by Google App Engine
This is Rietveld 408576698