Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 978123003: Merged INLINE_OPTIMIZED intrinsic type into INLINE. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Merged INLINE_OPTIMIZED intrinsic type into INLINE. BUG=v8:3947 LOG=n Committed: https://crrev.com/4e7acce180af72bac21db2a6f8d1a1d92d207579 Cr-Commit-Position: refs/heads/master@{#27039}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -83 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 3 chunks +9 lines, -10 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +14 lines, -13 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +6 lines, -7 lines 0 comments Download
M src/runtime/runtime.cc View 1 chunk +1 line, -10 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sven Panne
5 years, 9 months ago (2015-03-06 09:25:56 UTC) #2
Michael Starzinger
LGTM, just nits. https://codereview.chromium.org/978123003/diff/1/src/compiler/js-intrinsic-lowering.cc File src/compiler/js-intrinsic-lowering.cc (right): https://codereview.chromium.org/978123003/diff/1/src/compiler/js-intrinsic-lowering.cc#newcode35 src/compiler/js-intrinsic-lowering.cc:35: return ReduceInlineOptimizedConstructDouble(node); nit: Can we also ...
5 years, 9 months ago (2015-03-06 10:01:43 UTC) #3
Sven Panne
https://codereview.chromium.org/978123003/diff/1/src/compiler/js-intrinsic-lowering.cc File src/compiler/js-intrinsic-lowering.cc (right): https://codereview.chromium.org/978123003/diff/1/src/compiler/js-intrinsic-lowering.cc#newcode35 src/compiler/js-intrinsic-lowering.cc:35: return ReduceInlineOptimizedConstructDouble(node); On 2015/03/06 10:01:43, Michael Starzinger wrote: > ...
5 years, 9 months ago (2015-03-06 10:27:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978123003/20001
5 years, 9 months ago (2015-03-06 10:38:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-06 11:01:49 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 11:02:04 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4e7acce180af72bac21db2a6f8d1a1d92d207579
Cr-Commit-Position: refs/heads/master@{#27039}

Powered by Google App Engine
This is Rietveld 408576698