Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 978063002: [Contextual Search] Add new assets for promo. (Closed)

Created:
5 years, 9 months ago by pedro (no code reviews)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Add new assets for promo. BUG=441476 Committed: https://crrev.com/a8e635214679c50b9010d925d083f8e54b13ba92 Cr-Commit-Position: refs/heads/master@{#319287}

Patch Set 1 #

Messages

Total messages: 20 (7 generated)
pedro (no code reviews)
Donn, we need to upload the assets first, in a separate CL. So I'm creating ...
5 years, 9 months ago (2015-03-04 23:31:59 UTC) #2
Donn Denman
On 2015/03/04 23:31:59, pedrosimonetti wrote: > Donn, we need to upload the assets first, in ...
5 years, 9 months ago (2015-03-04 23:42:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978063002/1
5 years, 9 months ago (2015-03-05 01:54:00 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-05 01:54:02 UTC) #7
David Trainor- moved to gerrit
lgtm
5 years, 9 months ago (2015-03-05 01:54:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978063002/1
5 years, 9 months ago (2015-03-05 01:54:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/47429)
5 years, 9 months ago (2015-03-05 03:13:36 UTC) #12
pedro (no code reviews)
Hey Mathieu, we need to update the promo image. Could you please approve this change?
5 years, 9 months ago (2015-03-05 03:36:40 UTC) #14
Mathieu
lgtm
5 years, 9 months ago (2015-03-05 13:51:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978063002/1
5 years, 9 months ago (2015-03-05 18:17:06 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 18:21:25 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a8e635214679c50b9010d925d083f8e54b13ba92 Cr-Commit-Position: refs/heads/master@{#319287}
5 years, 9 months ago (2015-03-05 18:23:42 UTC) #19
pedro (no code reviews)
5 years, 9 months ago (2015-03-23 19:20:23 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1030703002/ by pedrosimonetti@chromium.org.

The reason for reverting is: We are going to replace multiple PNGs with a single
SVG..

Powered by Google App Engine
This is Rietveld 408576698