Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Issue 978053002: Add a basic template for chrome.browser apps API. (Closed)

Created:
5 years, 9 months ago by rpaquay
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a basic template for chrome.browser apps API. BUG=358315 NOTRY=true Committed: https://crrev.com/d1401a5e3668593c18458ffb4e19ad71a3962f84 Cr-Commit-Position: refs/heads/master@{#319163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A chrome/common/extensions/docs/templates/public/apps/browser.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rpaquay
5 years, 9 months ago (2015-03-04 23:20:21 UTC) #2
Ken Rockot(use gerrit already)
lgtm, but you should also add NOTRY=true to skip trybots for this
5 years, 9 months ago (2015-03-04 23:25:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978053002/1
5 years, 9 months ago (2015-03-04 23:41:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 23:42:19 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 23:43:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1401a5e3668593c18458ffb4e19ad71a3962f84
Cr-Commit-Position: refs/heads/master@{#319163}

Powered by Google App Engine
This is Rietveld 408576698