Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 977963002: make unimplemented statements throw (Closed)

Created:
5 years, 9 months ago by Jennifer Messerly
Modified:
5 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

make unimplemented statements throw (they'll hit visitNode) R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/9e0b8621c720b9a56677578d5d94cd369f197c30

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
doesn't seem worth keeping those two comments, since they don't appear in our test suite's ...
5 years, 9 months ago (2015-03-04 19:23:06 UTC) #3
vsm
lgtm
5 years, 9 months ago (2015-03-04 20:06:51 UTC) #4
Jennifer Messerly
5 years, 9 months ago (2015-03-17 17:00:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
9e0b8621c720b9a56677578d5d94cd369f197c30 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698