Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 977943003: Fix remoting GN Mac build. (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -284 lines) Patch
M remoting/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/host/BUILD.gn View 1 1 chunk +291 lines, -281 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
5 years, 9 months ago (2015-03-04 18:50:40 UTC) #1
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bc42260103b5e9357fd3b2c077acae804b55876d Cr-Commit-Position: refs/heads/master@{#319090}
5 years, 9 months ago (2015-03-04 18:54:07 UTC) #2
brettw
Committed patchset #2 (id:20001) manually as bc42260103b5e9357fd3b2c077acae804b55876d (presubmit successful).
5 years, 9 months ago (2015-03-04 18:54:17 UTC) #3
Dirk Pranke
5 years, 9 months ago (2015-03-04 18:54:30 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698