Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 977923002: Use bit_cast for Runtime_Double{Hi,Lo}. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use bit_cast for Runtime_Double{Hi,Lo}. To avoid undefined behavior. R=bmeurer@chromium.org Committed: https://crrev.com/eb27388b37f30d555da8456f17953fc6a5ff798c Cr-Commit-Position: refs/heads/master@{#26998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/runtime/runtime-maths.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 9 months ago (2015-03-04 14:54:41 UTC) #1
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-04 18:23:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977923002/1
5 years, 9 months ago (2015-03-04 18:54:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 18:55:11 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 18:55:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb27388b37f30d555da8456f17953fc6a5ff798c
Cr-Commit-Position: refs/heads/master@{#26998}

Powered by Google App Engine
This is Rietveld 408576698