Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 977893002: convert remaining object functions to maybes (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

convert remaining object functions to maybes BUG=v8:3929 LOG=y Committed: https://crrev.com/bde194974447853ee6dc30a72f898fb410c7e46b Cr-Commit-Position: refs/heads/master@{#26981}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -165 lines) Patch
M include/v8.h View 1 2 5 chunks +9 lines, -3 lines 0 comments Download
M src/api.cc View 1 13 chunks +137 lines, -162 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sven Panne
lgtm
5 years, 9 months ago (2015-03-04 12:45:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977893002/40001
5 years, 9 months ago (2015-03-04 12:46:57 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-04 12:58:35 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 12:58:51 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bde194974447853ee6dc30a72f898fb410c7e46b
Cr-Commit-Position: refs/heads/master@{#26981}

Powered by Google App Engine
This is Rietveld 408576698